Re: [PATCH net-next 09/16] dt-bindings: net: dwmac: Prohibit additional props in AXI-config

[Krzysztof Kozlowski]

On 13/03/2023 23:50, Serge Semin wrote:
> Currently DT-schema of the AXI-bus config sub-node prohibits to have
> unknown properties by using the unevaluatedProperties property. It's
> overkill for the sub-node which doesn't use any combining schemas
> keywords (allOf, anyOf, etc). Instead more natural is to use
> additionalProperties to prohibit for that.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 89be67e55c3e..d1b2910b799b 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -466,7 +466,6 @@ properties:
>  
>    stmmac-axi-config:
>      type: object
> -    unevaluatedProperties: false
>      description:
>        AXI BUS Mode parameters.
>  
> @@ -518,6 +517,8 @@ properties:
>          description:
>            rebuild INCRx Burst
>  
> +    additionalProperties: false

But why moving it? Keep the same placement.

Best regards,
Krzysztof