Re: [PATCH v2 2/5] iommu/vt-d: Allow SVA with device-specific IOPF

From: Baolu Lu
Date: Thu Mar 16 2023 - 03:35:13 EST


On 2023/3/16 15:09, Tian, Kevin wrote:
From: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
Sent: Thursday, March 9, 2023 10:57 AM

@@ -4650,7 +4650,18 @@ static int intel_iommu_enable_sva(struct device
*dev)
if (!(iommu->flags & VTD_FLAG_SVM_CAPABLE))
return -ENODEV;

- if (!info->pasid_enabled || !info->pri_enabled || !info->ats_enabled)
+ if (!info->pasid_enabled)
+ return -EINVAL;
+

I think you still want to check ats_enabled even for device specific IOPF.

Yeah! Updated.

Best regards,
baolu