Re: [PATCH v2] soundwire: bandwidth allocation: Use hweight32() to calculate set bits

From: Vinod Koul
Date: Thu Mar 16 2023 - 02:02:59 EST


On 15-03-23, 14:50, Richard Fitzgerald wrote:
> Replace the call to sdw_ch_mask_to_ch() with a call to hweight32().
>
> sdw_ch_mask_to_ch() is counting the number of set bits. The hweight()
> family of functions already do this, and they have an advantage of
> using a bit-counting instruction if it is available on the target CPU.
> This also fixes a potential infinite loop bug in the implementation of
> sdw_ch_mask_to_ch().

Applied, thanks

--
~Vinod