Re: [PATCH] cpufreq: pmac32: Use of_property_read_bool() for boolean properties

[Michael Ellerman]

Rob Herring <robh@xxxxxxxxxx> writes:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>  drivers/cpufreq/pmac32-cpufreq.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>

cheers

> diff --git a/drivers/cpufreq/pmac32-cpufreq.c b/drivers/cpufreq/pmac32-cpufreq.c
> index 4b8ee2014da6..7ec6d1bb4592 100644
> --- a/drivers/cpufreq/pmac32-cpufreq.c
> +++ b/drivers/cpufreq/pmac32-cpufreq.c
> @@ -546,7 +546,7 @@ static int pmac_cpufreq_init_7447A(struct device_node *cpunode)
>  {
>  	struct device_node *volt_gpio_np;
>  
> -	if (of_get_property(cpunode, "dynamic-power-step", NULL) == NULL)
> +	if (!of_property_read_bool(cpunode, "dynamic-power-step"))
>  		return 1;
>  
>  	volt_gpio_np = of_find_node_by_name(NULL, "cpu-vcore-select");
> @@ -576,7 +576,7 @@ static int pmac_cpufreq_init_750FX(struct device_node *cpunode)
>  	u32 pvr;
>  	const u32 *value;
>  
> -	if (of_get_property(cpunode, "dynamic-power-step", NULL) == NULL)
> +	if (!of_property_read_bool(cpunode, "dynamic-power-step"))
>  		return 1;
>  
>  	hi_freq = cur_freq;
> @@ -632,7 +632,7 @@ static int __init pmac_cpufreq_setup(void)
>  
>  	/*  Check for 7447A based MacRISC3 */
>  	if (of_machine_is_compatible("MacRISC3") &&
> -	    of_get_property(cpunode, "dynamic-power-step", NULL) &&
> +	    of_property_read_bool(cpunode, "dynamic-power-step") &&
>  	    PVR_VER(mfspr(SPRN_PVR)) == 0x8003) {
>  		pmac_cpufreq_init_7447A(cpunode);
>  
> -- 
> 2.39.2