Re: [PATCH net-next] net: mdio: Add netlink interface
From: kernel test robot
Date: Mon Mar 06 2023 - 19:07:24 EST
Hi Sean,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/net-mdio-Add-netlink-interface/20230307-044742
patch link: https://lore.kernel.org/r/20230306204517.1953122-1-sean.anderson%40seco.com
patch subject: [PATCH net-next] net: mdio: Add netlink interface
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230307/202303070724.WmNAt4Af-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/78ff5545f403a98977a2db207cc165cb3a3b4d8f
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sean-Anderson/net-mdio-Add-netlink-interface/20230307-044742
git checkout 78ff5545f403a98977a2db207cc165cb3a3b4d8f
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/net/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202303070724.WmNAt4Af-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/net/mdio/mdio-netlink.c: In function 'mdio_nl_eval':
>> drivers/net/mdio/mdio-netlink.c:98:40: warning: variable 'val' set but not used [-Wunused-but-set-variable]
98 | int phy_id, reg, prtad, devad, val;
| ^~~
vim +/val +98 drivers/net/mdio/mdio-netlink.c
91
92 static int mdio_nl_eval(struct mdio_nl_xfer *xfer)
93 {
94 struct mdio_nl_insn *insn;
95 unsigned long timeout;
96 u16 regs[8] = { 0 };
97 int pc, ret = 0;
> 98 int phy_id, reg, prtad, devad, val;
99
100 timeout = jiffies + msecs_to_jiffies(xfer->timeout_ms);
101
102 mutex_lock(&xfer->mdio->mdio_lock);
103
104 for (insn = xfer->prog, pc = 0;
105 pc < xfer->prog_len;
106 insn = &xfer->prog[++pc]) {
107 if (time_after(jiffies, timeout)) {
108 ret = -ETIMEDOUT;
109 break;
110 }
111
112 switch ((enum mdio_nl_op)insn->op) {
113 case MDIO_NL_OP_READ:
114 phy_id = __arg_ri(insn->arg0, regs);
115 prtad = mdio_phy_id_prtad(phy_id);
116 devad = mdio_phy_id_devad(phy_id);
117 reg = __arg_ri(insn->arg1, regs);
118
119 if (mdio_phy_id_is_c45(phy_id))
120 ret = __mdiobus_c45_read(xfer->mdio, prtad,
121 devad, reg);
122 else
123 ret = __mdiobus_read(xfer->mdio, phy_id, reg);
124
125 if (ret < 0)
126 goto exit;
127 *__arg_r(insn->arg2, regs) = ret;
128 ret = 0;
129 break;
130
131 case MDIO_NL_OP_WRITE:
132 phy_id = __arg_ri(insn->arg0, regs);
133 prtad = mdio_phy_id_prtad(phy_id);
134 devad = mdio_phy_id_devad(phy_id);
135 reg = __arg_ri(insn->arg1, regs);
136 val = __arg_ri(insn->arg2, regs);
137
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests