Re: [PATCH v1 1/2] dt-bindings: PWM: Add StarFive PWM module

[William Qiu]

On 2023/2/28 22:07, Krzysztof Kozlowski wrote:
> On 28/02/2023 10:13, William Qiu wrote:
>> Add documentation to describe StarFive Pulse Width Modulation
>> controller driver.
>> 
>> Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx>
>> ---
>>  .../devicetree/bindings/pwm/pwm-starfive.yaml | 54 +++++++++++++++++++
>>  1 file changed, 54 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-starfive.yaml
>> 
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-starfive.yaml b/Documentation/devicetree/bindings/pwm/pwm-starfive.yaml
>> new file mode 100644
>> index 000000000000..4ba2a8cc5344
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-starfive.yaml
> 
> Filename based on compatible, so starfive,jh7110-pwm.yaml
> 
>> @@ -0,0 +1,54 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pwm/pwm-starfive.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: StarFive PWM controller
>> +
>> +maintainers:
>> +  - William Qiu <william.qiu@xxxxxxxxxxxxxxxx>
>> +
>> +description:
>> +  StarFive SoCs contain PWM and when operating in PWM mode, the PTC core generates
>> +  binary signal with user-programmable low and high periods. Clock source for the
>> +  PWM can be either system clockor external clock. Each PWM timer block provides 8
>> +  PWM channels.
>> +
>> +allOf:
>> +  - $ref: pwm.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    items:
> 
> Drop items, not a list in your case.
> 

Will drop. Thanks for taking time reviewing this patch series.

Best regards
William
>> +      - const: starfive,jh7110-pwm
>> +
> 
> 
> Best regards,
> Krzysztof
>