Re: [PATCH v2 00/20] Some bugfix and cleanup to mballoc

From: Theodore Ts'o
Date: Tue Feb 28 2023 - 17:32:51 EST


On Tue, Feb 28, 2023 at 10:04:35PM +0530, Ritesh Harjani wrote:
> Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> writes:
>
> > Hi, this series contain some random cleanup patches and some bugfix
> > patches to make EXT4_MB_HINT_GOAL_ONLY work properly, protect pa->pa_free
> > from race and so on. More details can be found in git log.
> > Thanks!
>
> Hi Kemeng,
>
> Did you run any testing on these patches? Because I was very easily able
> to hit ext/009 causing kernel BUG_ON with default mkfs/mount options.
> It's always a good and recommended practice to ensure some level of
> testing on any of the patches we submit to community for review
> and call out in the cover letter on what has been tested and what is not.

Hi Kemeng,

If you need help running xfstests, I maintain a test appliance which
makes it very easy to run xfstests on development kernels. Please see:

https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-xfstests.md
https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md

This test appliance can also be run on Android devices and using
Google Compute Engine; for more information see:

https://thunk.org/android-xfstests
https://thunk.org/gce-xfstests

If you're just getting started, I recommend that you start with
kvm-xfstests, and this is the simplest way to get started.

Cheers,

- Ted