Re: [PATCH v2 2/2] leds: add aw20xx driver

[Pavel Machek]

Hi!

> +config LEDS_AW200XX
> +	tristate "LED support for Awinic AW20036/AW20054/AW20072"
> +	depends on LEDS_CLASS
> +	depends on I2C
> +	help
> +	  This option enables support for the AW20036/AW20054/AW20072 LED driver.
> +	  It is a 3x12/6x9/6x12 matrix LED driver programmed via
> +	  an I2C interface, up to 36/54/72 LEDs or 12/18/24 RGBs,
> +	  3 pattern controllers for auto breathing or group dimming control.

I'm afraid this should be handled as a display, not as an array of
individual LEDs.

Plus RGB LEDs should certainly be handled using multicolor class.

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Attachment: signature.asc
Description: PGP signature