Re: [PATCH v8 2/3] mfd: axp20x: Add support for AXP313a PMIC

From: Martin Botka
Date: Tue Feb 28 2023 - 16:11:29 EST



Hi Shengyu
On Sun, Feb 19 2023 at 01:52:50 AM +08:00:00, Shengyu Qu <wiagn233@xxxxxxxxxxx> wrote:
Hi Martin,
+static const struct regmap_range axp313a_writeable_ranges[] = {
+ regmap_reg_range(AXP313A_ON_INDICATE, AXP313A_IRQ_STATE),
No, according to datasheet, 0x00 reg is read-only.
+};
+
+static const struct regmap_range axp313a_volatile_ranges[] = {
+ regmap_reg_range(AXP313A_ON_INDICATE, AXP313A_IRQ_STATE),

As Tsai said, no meaning to set all register to volatile.
ack

Also, please check the datasheet I metioned in part3 reply, seems its
newer than yours.
ack

Best regards,

Shengyu

Best regards,

Martin