Re: [PATCH v2 0/2] dyndbg: let's use the module notifier callback

From: Luis Chamberlain
Date: Tue Feb 28 2023 - 15:18:32 EST


On Tue, Feb 28, 2023 at 02:34:20PM -0500, Jason Baron wrote:
> Hi,
>
> Jim Cromie hit a BUG() while toggling jump label branches in a module
> before they were properly initialized. This isn't currently an issue,
> but will be as part of his pending classmap series. Seems like we
> should covert to using module callback notifier for dynamic debug
> anyways. First patch is just a cleanup.
>
> Link: https://lore.kernel.org/lkml/20230113193016.749791-21-jim.cromie@xxxxxxxxx/
>
> Thanks,
>
> -Jason
>
> v2:
> -Fix: error: field 'dyndbg_info' has incomplete type
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Link: https://lore.kernel.org/oe-kbuild-all/202302190427.9iIK2NfJ-lkp@xxxxxxxxx/
> -make ddebug_remove_module() static

Do you have tests to ensure no regressions have occurred? If so what
are they? If there are no tests, can you come up with some basic ones?

Luis