Re: [PATCH 0/3] Improve trace/ring_buffer.c

From: Steven Rostedt
Date: Tue Feb 28 2023 - 14:35:56 EST


On Tue, 28 Feb 2023 18:59:26 +0100
Uros Bizjak <ubizjak@xxxxxxxxx> wrote:

> This series improves ring_buffer.c by changing the type of some
> static functions to void or bool and

Well, it's not really an improvement unless it has a functional change. But
I'm OK with taking these.

> uses try_cmpxchg instead of
> cmpxchg (*ptr, old, new) == old where appropriate.

Now, the try_cmpxchg() could be an improvement on x86.

-- Steve

>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
>
> Uros Bizjak (3):
> ring_buffer: Change some static functions to void
> ring_buffer: Change some static functions to bool
> ring_buffer: Use try_cmpxchg instead of cmpxchg
>
> kernel/trace/ring_buffer.c | 89 ++++++++++++++++----------------------
> 1 file changed, 37 insertions(+), 52 deletions(-)
>