RE: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules

[Keller, Jacob E]

> -----Original Message-----
> From: Nick Alcock <nick.alcock@xxxxxxxxxx>
> Sent: Tuesday, February 28, 2023 5:02 AM
> To: mcgrof@xxxxxxxxxx
> Cc: linux-modules@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Hitomi
> Hasegawa <hasegawa-hitomi@xxxxxxxxxxx>; Keller, Jacob E
> <jacob.e.keller@xxxxxxxxx>
> Subject: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules
> 
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock@xxxxxxxxxx>
> Suggested-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> Cc: linux-modules@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Hitomi Hasegawa <hasegawa-hitomi@xxxxxxxxxxx>
> Cc: Jacob Keller <jacob.e.keller@xxxxxxxxx>

Acked-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>

> ---
>  lib/pldmfw/pldmfw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/pldmfw/pldmfw.c b/lib/pldmfw/pldmfw.c
> index 6e77eb6d8e72e..54e1809a38fd9 100644
> --- a/lib/pldmfw/pldmfw.c
> +++ b/lib/pldmfw/pldmfw.c
> @@ -875,5 +875,4 @@ int pldmfw_flash_image(struct pldmfw *context, const
> struct firmware *fw)
>  EXPORT_SYMBOL(pldmfw_flash_image);
> 
>  MODULE_AUTHOR("Jacob Keller <jacob.e.keller@xxxxxxxxx>");
> -MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("PLDM firmware flash update library");
> --
> 2.39.1.268.g9de2f9a303