Re: [PATCH 12/18] media: venus: firmware: Correct IS_V6() checks

From: Bryan O'Donoghue
Date: Tue Feb 28 2023 - 10:48:55 EST


On 28/02/2023 15:24, Konrad Dybcio wrote:
- if (IS_V6(core))
+ /*
+ * This may sound counter-intuitive, but when there's no TZ, we gotta
+ * do things that it would otherwise do for us, such as initializing
+ * the hardware at a very basic level.
+ * */

Suggest "When there is no TZ we have got to initialize hardware in-lieu of TZ" as an example.

Either way please drop that "gotta" - I ain't gonna ACK such a butchering of the language.

Then

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>