Re: [PATCH v2 13/14] perf kvm: Add TUI mode for stat report

[Leo Yan]

Hi James,

On Tue, Feb 28, 2023 at 11:12:17AM +0000, James Clark wrote:

[...]

> > +static void print_result(struct perf_kvm_stat *kvm);
> > +
> > +#ifdef HAVE_SLANG_SUPPORT
> 
> Hi Leo,
> 
> I get an error because of this addition when building on x86. I think
> it's because I don't have HAVE_SLANG_SUPPORT. It might be the same error
> that you mentioned on v1?
> 
>    builtin-kvm.c:535:13: error: ‘print_result’ used but never defined
> [-Werror]
>    535 | static void print_result(struct perf_kvm_stat *kvm);

It's a bit weird for reporting this issue, since you could see I have
moved the function definition for print_result() ahead the macro
condition '#ifdef HAVE_SLANG_SUPPORT'.

But I found building failure with below command:

  $ make VF=1 DEBUG=1 NO_SLANG=1

Let me repin this patch for the building failures; sorry I have been
negligent.

> Other than that, for the whole set:
> 
> Reviewed-by: James Clark <james.clark@xxxxxxx>

Thanks a lot for reviewing!  I will apply your tag in next spin
except patch 13.

Leo