Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus

From: Arnd Bergmann
Date: Tue Feb 28 2023 - 03:37:51 EST


On Tue, Feb 28, 2023, at 04:57, Larry Finger wrote:
> On 2/27/23 15:30, Arnd Bergmann wrote:
>
> It was a configuration problem. In the .config obtained by installing
> your
> patches, and doing a make, CONFIG_CARDBUS was not mentioned, and
> CONFIG_PCI_HOTPLUG was not selected. When I deleted the reference to
> the latter,
> did a make, and set ..._HOTPLUG, I got CONFIG+CARDBUS set to "m", and
> the yenta
> modules were built. This version sees the BCM4318 in the lspci scan,
> and the
> interface works. Your patches are OK.

Ok, great, thanks for testing!

> I am not sure how to warn people about the configuration change possible
> breaking things.

My intention was to keep Cardbus support working with old defconfig files,
and I've not moved CONFIG_CARDBUS into a separate submenu between
CONFIG_PCI_HOTPLUG and CONFIG_PCI_CONTROLLER but left the driver in
drivers/pci/hotplug. I think that's the best compromise here, but maybe
the PCI maintainers have a better idea.

Arnd