Re: [PATCH v7 1/4] tools/nolibc: add stdint.h

[Thomas Weißschuh]

On Mon, Feb 27, 2023 at 09:11:33PM -0500, Vincent Dagonneau wrote:
> Nolibc works fine for small and limited program however most program
> expect integer types to be defined in stdint.h rather than std.h.
> 
> This is a quick fix that moves the existing integer definitions in std.h
> to stdint.h.
> 
> Signed-off-by: Vincent Dagonneau <v@xxxxxx>
> Signed-off-by: Willy Tarreau <w@xxxxxx>
> Reviewed-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

One more nitpick (applies to all patches):

The correct order of trailers would be:

Signed-off-by: Willy Tarreau <w@xxxxxx>
Reviewed-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
Signed-off-by: Vincent Dagonneau <v@xxxxxx>

In chronological order.

First Willy submitted something, then I reviewed it and then you
submitted it.
Your previous submissions/Signed-off-by are superseeded by the last one.

See Documentation/process/submitting-patches.rst.
(Especially search for "chronological")

Willy can probably fix this up when applying the series, so a new
revision may not be necessary.

> ---
>  tools/include/nolibc/Makefile |  4 ++--
>  tools/include/nolibc/std.h    | 15 +--------------
>  tools/include/nolibc/stdint.h | 24 ++++++++++++++++++++++++
>  3 files changed, 27 insertions(+), 16 deletions(-)
>  create mode 100644 tools/include/nolibc/stdint.h