Re: [PATCH v6 0/4] tools/nolibc: Adding stdint.h, more integer types and tests

From: Vincent Dagonneau
Date: Mon Feb 27 2023 - 21:08:29 EST


On Wed, Feb 22, 2023, at 21:56, Willy Tarreau wrote:
> On Thu, Feb 23, 2023 at 01:53:06AM +0000, Thomas Weißschuh wrote:
>> On Wed, Feb 22, 2023 at 08:00:21PM -0500, Vincent Dagonneau wrote:
>> > Hi,
>> >
>> > This is version 6 of the patch to add stdint.h to nolibc. Previous
>> > versions of this patch are available here:
>> >
>> > * v5: https://lore.kernel.org/all/20230220202010.37475-1-v@xxxxxx/
>> > * v4: https://lore.kernel.org/all/20230209024044.13127-1-v@xxxxxx/
>> > * v3: https://lore.kernel.org/all/20230206013248.471664-1-v@xxxxxx/
>> > * v2: https://lore.kernel.org/all/20230202201101.43160-1-v@xxxxxx/
>> > * v1: https://lore.kernel.org/all/20230202160236.25342-1-v@xxxxxx/
>> >
>> > This version integrates the feedback from Thomas, removing the limits
>> > for ssize_t (not required by the standard) as well as multiple cosmetic
>> > issues.
>>
>> Thanks, for the whole series:
>>
>> Reviewed-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
>
> Thanks to you both! I'll take care of all this this week-end.
>
>> Note:
>>
>> When sending new revisions it makes sense to add reviewers and
>> commenters of the previous versions on Cc.
>>
>> It makes it easier for them and gives you a faster review or
>> Reviewed-by.
>
> Agreed. Overall I find that for his first patchset Vincent has
> done a great job ;-)
>

Thank you for your guidance on this patchset!

> Cheers,
> Willy