Re: [PATCH v5 2/2] hwmon: (sfctemp) Add StarFive JH71x0 temperature sensor

[Conor Dooley]

On Mon, Feb 27, 2023 at 09:41:25PM +0800, Hal Feng wrote:
> From: Emil Renner Berthing <kernel@xxxxxxxx>
> 
> Add driver for the StarFive JH71x0 temperature sensor. You
> can enable/disable it and read temperature in milli Celcius
> through sysfs.
> 
> Signed-off-by: Emil Renner Berthing <kernel@xxxxxxxx>
> Co-developed-by: Samin Guo <samin.guo@xxxxxxxxxxxxxxxx>
> Signed-off-by: Samin Guo <samin.guo@xxxxxxxxxxxxxxxx>
> Signed-off-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>

> +config SENSORS_SFCTEMP
> +	tristate "Starfive JH71x0 temperature sensor"
> +	depends on SOC_STARFIVE || COMPILE_TEST

We (or I?) am trying to homogenise RISC-V with the rest of the kernel by
using ARCH_FOO rather than SOC_FOO. We've currently got a mix of both,
due to companies that started out with RISC-V having SOC_ symbols &
those with history in other archs having ARCH_ ones.
The ARCH_ definitions landed in mainline this week, so if you end up
resubmitting this driver, it'd save me a conversion if you were to use
the ARCH_ variant.

Thanks,
Conor.

> +	help
> +	  If you say yes here you get support for temperature sensor
> +	  on the Starfive JH71x0 SoCs.
> +
> +	  This driver can also be built as a module.  If so, the module
> +	  will be called sfctemp.

Attachment: signature.asc
Description: PGP signature