Re: [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it

From: Pavel Machek
Date: Mon Feb 27 2023 - 06:38:03 EST


On Sat 2023-02-25 21:39:49, Randy Dunlap wrote:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Dan Murphy <dmurphy@xxxxxx>

Acked-by: Pavel Machek <pavel@xxxxxx>

Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.

Attachment: signature.asc
Description: PGP signature