+Arnd
On Tue, Feb 21, 2023 at 03:29:39AM +0100, Andrew Lunn wrote:
On Mon, Feb 20, 2023 at 07:46:13AM +0100, Simon Horman wrote:Yes, that would be a good improvement.
On Mon, Feb 20, 2023 at 02:19:34AM +0100, Andrew Lunn wrote:O.K. So the commit message needs updating to describe the actual
On Sun, Feb 19, 2023 at 07:16:07PM +0100, Simon Horman wrote:Thanks Andrew,
On Sun, Feb 19, 2023 at 10:03:21AM -0500, Tom Rix wrote:I'n guessing, but it could be that LAN743X is built in, and FIXED_PHY
A rand config causes this link errorHi Tom,
drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netdev_open':
drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference to `fixed_phy_register'
lan743x_netdev_open is controlled by LAN743X
fixed_phy_register is controlled by FIXED_PHY
So LAN743X should also select FIXED_PHY
Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
I am a little confused by this.
I did manage to cook up a config with LAN743X=m and FIXED_PHY not set.
But I do not see a build failure, and I believe that is because
when FIXED_PHY is not set then a stub version of fixed_phy_register(),
defined as static inline in include/linux/phy_fixed.h, is used.
Ref: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/include/linux/phy_fixed.h?h=main&id=675f176b4dcc2b75adbcea7ba0e9a649527f53bd#n42
is a module? What might be needed is
depends on FIXED_PHY || FIXED_PHY=n
LAN743X=y and FIXED_PHY=m does indeed produce the problem that Tom
describes. And his patch does appear to resolve the problem.
problem.
Perhaps a fixes tag too?
I _think_ the patch, which uses select FIXED_PHY for LAN743X,Unfortunately your proposed solution seems to run foul of a complexI was never any good at Kconfig. Arnd is the expert at solving
dependency situation.
problems like this.
You want either everything built in, or FIXED_PHY built in and LAN743X
modular, or both modular.
achieves that.
I CCed Arnd in case he has any input. Though I think I read
in an recent email from him that he is out most of this week.