Re: [PATCH] zram: Use atomic_long_read() to read atomic_long_t

[Geert Uytterhoeven]

Hi Andrew,

On Sun, Feb 26, 2023 at 5:57 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, 25 Feb 2023 20:30:52 -0800 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > Fix this by using atomic_long_read() instead.
> > >
> > > Reported-by; noreply@xxxxxxxxxxxxxx
> >
> > That's an interesting one.  Was this mpe@?

No, from the kisskb build bot, which sends private emails to the
architecture maintainers when one of their builds fail:

----8<-------------------------------------------------------------------------------------------
Subject: kisskb: FAILED linux-next/m68k-defconfig/m68k-gcc8 Sat Feb 25, 14:34
From: noreply@xxxxxxxxxxxxxx
To: geert@xxxxxxxxxxxxxx
Date: Sat, 25 Feb 2023 03:35:59 -0000
Message-ID: <20230225033559.1.93322@37da20578230>

FAILED linux-next/m68k-defconfig/m68k-gcc8 Sat Feb 25, 14:34

http://kisskb.ellerman.id.au/kisskb/buildresult/14885627/

Commit:   Add linux-next specific files for 20230225
          8232539f864ca60474e38eb42d451f5c26415856
Compiler: m68k-linux-gcc (GCC) 8.5.0 / GNU ld (GNU Binutils) 2.36.1

Possible errors
---------------

drivers/block/zram/zram_drv.c:1234:23: error: passing argument 1 of
'atomic64_read' from incompatible pointer type
[-Werror=incompatible-pointer-types]
cc1: some warnings being treated as errors
make[5]: *** [scripts/Makefile.build:252: drivers/block/zram/zram_drv.o] Error 1
make[4]: *** [scripts/Makefile.build:494: drivers/block/zram] Error 2
make[3]: *** [scripts/Makefile.build:494: drivers/block] Error 2
make[2]: *** [scripts/Makefile.build:494: drivers] Error 2
make[1]: *** [Makefile:2028: .] Error 2
make: *** [Makefile:226: __sub-make] Error 2

Possible warnings (1)
----------------------

include/linux/list.h:74:12: warning: 'seed_devices' may be used
uninitialized in this function [-Wmaybe-uninitialized]
------------------------------------------------------------------------------------------>8-----

> > I like it when a Reported-by: is followed by a Link: to the report, so
> > I can go hunt down such things.
>
> I found this, and added it to the changelog:
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>   Link: https://lore.kernel.org/oe-kbuild-all/202302241840.nwdXqE5r-lkp@xxxxxxxxx/

That's a different bot ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds