Re: [PATCH] x86/CPU/AMD: Make sure EFER[AIBRSE] is set

From: Josh Poimboeuf
Date: Sat Feb 25 2023 - 18:43:38 EST


On Sat, Feb 25, 2023 at 11:56:37PM +0100, Borislav Petkov wrote:
> On Sat, Feb 25, 2023 at 09:28:32AM -0800, Josh Poimboeuf wrote:
> > All the other "bug" code in identify_secondary_cpu() *is*
> > vendor-specific.
>
> I meant "vendor-specific" in the sense that AMD code goes to amd.c, etc.

Hm? So code in bugs.c is not vendor-specific? That seems circular and
I don't get your point.

> As to the identify_secondary_cpu() code - I didn't like it being
> slapped there either but it got stuck in there hastily during the
> mitigations upstreaming as back then we had bigger fish to fry than
> paying too much attention to clean design...

Right, so rather than spreading all the bug-related MSR logic around,
just do it in one spot.

--
Josh