Re: [PATCH] can: esd_usb: Improve code readability by means of replacing struct esd_usb_msg with a union

From: Vincent MAILHOL
Date: Sat Feb 25 2023 - 03:35:54 EST


On Thu. 23 Feb. 2023 at 01:56, Frank Jungclaus <frank.jungclaus@xxxxxx> wrote:
> As suggested by Vincent Mailhol, declare struct esd_usb_msg as a union
> instead of a struct. Then replace all msg->msg.something constructs,
> that make use of esd_usb_msg, with simpler and prettier looking
> msg->something variants.
>
> Link: https://lore.kernel.org/all/CAMZ6RqKRzJwmMShVT9QKwiQ5LJaQupYqkPkKjhRBsP=12QYpfA@xxxxxxxxxxxxxx/
> Suggested-by: Vincent MAILHOL <mailhol.vincent@xxxxxxxxxx>
> Signed-off-by: Frank Jungclaus <frank.jungclaus@xxxxxx>

Thank you for your follow up on this and on all my other comments.

Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>