Re: [PATCH RFC Vb] bgmac: fix *initial* chip reset to support BCM5358

[Florian Fainelli]

On 2/24/23 05:48, Rafał Miłecki wrote:
> While bringing hardware up we should perform a full reset including the
> switch bit (BGMAC_BCMA_IOCTL_SW_RESET aka SICF_SWRST). It's what
> specification says and what reference driver does.
>
> This seems to be critical for the BCM5358. Without this hardware doesn't
> get initialized properly and doesn't seem to transmit or receive any
> packets.
>
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
> ---
> RFC: This is alternative solutionto the
> [PATCH RFC] bgmac: fix *initial* chip reset to support BCM5358
> https://lore.kernel.org/lkml/20230207225327.27534-1-zajec5@xxxxxxxxx/T/
>
> Any comments on the prefered solution? Parameter vs. flag?

Seems to me that the flags have been used to express 
features/quirks/capabilities as much as what you are trying to do here, 
flag would be my preference. LGTM otherwise.
--
Florian