Re: [PATCH] spi: tegra210-quad: Fix iterator outside loop

From: Mark Brown
Date: Fri Feb 24 2023 - 11:47:14 EST


On Fri, Feb 24, 2023 at 10:05:13PM +0530, Krishna Yarlagadda wrote:

> msg->actual_length += xfer->len;
> + if (!xfer->cs_change && transfer_phase == DATA_TRANSFER) {
> + tegra_qspi_transfer_end(spi);
> + spi_transfer_delay_exec(xfer);
> + }
> transfer_phase++;
> }
> - if (!xfer->cs_change) {
> - tegra_qspi_transfer_end(spi);
> - spi_transfer_delay_exec(xfer);
> - }

This looks like it'll do the wrong thing and do a change on every
transfer if cs_change isn't set?

Attachment: signature.asc
Description: PGP signature