Re: [PATCH v2 net-next 3/5] net: dsa: microchip: add eth mac grouping for ethtool statistics

From: Alexander Lobakin
Date: Fri Feb 24 2023 - 11:08:42 EST


From: Vladimir Oltean <olteanv@xxxxxxxxx>
Date: Fri, 17 Feb 2023 18:42:27 +0200

> On Fri, Feb 17, 2023 at 04:01:15PM +0100, Alexander Lobakin wrote:
>>> + ++mib->cnt_ptr;
>>
>> Reason for the pre-increment? :)
>
> because it's kool

:D The most common reason for it usually ._.

>
> Somebody not that long ago suggested that pre-increment is "less resource consuming":
> https://patchwork.kernel.org/project/netdevbpf/patch/677a5e37aab97a4f992d35c41329733c5f3082fb.1675407169.git.daniel@xxxxxxxxxxxxxx/#25197216
>
> Of course, when pressed to explain more, he stopped responding.

Haha, classics.
It's not so common for people to show up back in the thread after you
ask them to show godbolt / asm code comparison.

Olek