Re: [PATCH] block: ublk: enable zoned storage support

From: Niklas Cassel
Date: Fri Feb 24 2023 - 11:03:01 EST


On Fri, Feb 24, 2023 at 04:53:52PM +0100, Niklas Cassel wrote:
> Hello Andreas,
>
> On Fri, Feb 24, 2023 at 01:59:50PM +0100, Andreas Hindborg wrote:
> > Add zoned storage support to ublk: report_zones and operations:
> > - REQ_OP_ZONE_OPEN
> > - REQ_OP_ZONE_CLOSE
> > - REQ_OP_ZONE_FINISH
> > - REQ_OP_ZONE_RESET
> >
> > This allows implementation of zoned storage devices in user space. An
> > example user space implementation based on ubdsrv is available [1].
> >
> > [1] https://github.com/metaspace/ubdsrv/commit/14a2b708f74f70cfecb076d92e680dc718cc1f6d
> >
> > Signed-off-by: Andreas Hindborg <a.hindborg@xxxxxxxxxxx>
> > ---
>
> Did you try to build this patch with CONFIG_BLK_DEV_ZONED disabled?
>
> I got the following build errors when building it on top of vanilla v6.2
> when CONFIG_BLK_DEV_ZONED is disabled:
>
> drivers/block/ublk_drv.c: In function ‘ublk_dev_param_basic_apply’:
> drivers/block/ublk_drv.c:221:28: error: ‘struct gendisk’ has no member named ‘nr_zones’
> 221 | ub->ub_disk->nr_zones = p->dev_sectors / p->chunk_sectors;
> | ^~
> drivers/block/ublk_drv.c: In function ‘ublk_dev_param_zoned_apply’:
> drivers/block/ublk_drv.c:244:17: error: implicit declaration of function ‘disk_set_max_active_zones’; did you mean ‘bdev_max_active_zones’? [-Werror=implicit-function-declaration]
> 244 | disk_set_max_active_zones(ub->ub_disk, p->max_active_zones);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> | bdev_max_active_zones
> drivers/block/ublk_drv.c:245:17: error: implicit declaration of function ‘disk_set_max_open_zones’; did you mean ‘bdev_max_open_zones’? [-Werror=implicit-function-declaration]
> 245 | disk_set_max_open_zones(ub->ub_disk, p->max_open_zones);
>

The problem here is probably that blkdev.h does not have dummy functions for
disk_set_max_active_zones() and disk_set_max_open_zones()

in the:
#else /* CONFIG_BLK_DEV_ZONED */
case.

I do see dummy functions in blkdev.h for disk_nr_zones(), disk_zone_is_seq()
and disk_zone_no() when CONFIG_BLK_DEV_ZONED is not set.


Kind regards,
Niklas