Re: [Patch V3 1/3] tpm_tis-spi: Support hardware wait polling

From: Mark Brown
Date: Fri Feb 24 2023 - 10:51:55 EST


On Fri, Feb 24, 2023 at 02:16:27PM +0000, Krishna Yarlagadda wrote:

> > > > > + spi_bus_lock(phy->spi_device->master);
> > > > > +
> > > > > + while (len) {

> > > > Why?

> > > TPM supports max 64B in single transaction. Loop to send rest of it.

> > No, why is there a bus lock?

> Bus lock to avoid other clients to be accessed between TPM transfers.

That's what a bus lock does but what would be the problem if something
else sent a message between messages? Note that a message will always
be sent atomically.

Attachment: signature.asc
Description: PGP signature