Re: [PATCH v3 02/11] dt-bindings: gpu: mali-bifrost: Split out MediaTek power-domains variation

[AngeloGioacchino Del Regno]

Il 24/02/23 11:09, Chen-Yu Tsai ha scritto:
> On Fri, Feb 24, 2023 at 6:08 PM Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote:
> > On Thu, Feb 23, 2023 at 9:34 PM AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
> > > In preparation for adding new bindings for new MediaTek SoCs, split out
> > > the power-domain-names and power-domainsvariation from the `else` in
>
>                                              ^ missing space
>
> Once fixed,

I think you even mentioned that already, ugh. Will fix.

> Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
>
> > > the current mediatek,mt8183-mali conditional.
> > >
> > > The sram-supply part is left in place to be disallowed for anything
> > > that is not compatible with "mediatek,mt8183-mali" as this regulator
> > > is MediaTek-specific and it is, and will ever be, used only for this
> > > specific string due to the addition of the mediatek-regulator-coupler
> > > driver.
> > >
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> >
> > Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>