Re: [PATCH 2/2] mfd: tps65219: Add gpio cell instance
From: andy . shevchenko
Date: Fri Feb 24 2023 - 07:17:35 EST
Fri, Feb 24, 2023 at 12:38:37PM +0100, Jerome Neanne kirjoitti:
> tps65219 PMIC GPIOs are exposed in a standard way:
> gpiodetect
> gpiochip0 [tps65219-gpio] (3 lines)
>
> Signed-off-by: Jonathan Cormier <jcormier@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jerome Neanne <jneanne@xxxxxxxxxxxx>
Same issues with the commit message as per previous patch.
...
> @@ -267,6 +267,11 @@ static int tps65219_probe(struct i2c_client *client)
> return ret;
> }
>
> + if (ret) {
> + dev_err(tps->dev, "Failed to add gpio: %d\n", ret);
> + return ret;
> + }
Isn't it a dead code?
--
With Best Regards,
Andy Shevchenko