Re: [PATCH net-next] wifi: wcn36xx: Slightly optimize PREPARE_HAL_BUF()

From: Kalle Valo
Date: Fri Feb 24 2023 - 05:23:27 EST


Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:

> In most (likely all) cases, INIT_HAL_MSG() is called before
> PREPARE_HAL_BUF().
> In such cases calling memset() is useless because:
> msg_body.header.len = sizeof(msg_body)
>
> So, instead of writing twice the memory, we just have a sanity check to
> make sure that some potential trailing memory is zeroed.
> It even gives the opportunity to see that by itself and optimize it away.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Acked-by: Loic Poulain <loic.poulain@xxxxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

4a51e66fe96d wifi: wcn36xx: Slightly optimize PREPARE_HAL_BUF()

--
https://patchwork.kernel.org/project/linux-wireless/patch/7d8ab7fee45222cdbaf80c507525f2d3941587c1.1675371372.git.christophe.jaillet@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches