Re: [PATCH v2 5/7] scsi: ufs: core: Remove redundant check

From: Ziqi Chen
Date: Thu Feb 23 2023 - 05:53:47 EST



On 2/22/2023 11:04 AM, Po-Wen Kao wrote:
is_mcq_supported() already check on use_mcq_mode.

Signed-off-by: Po-Wen Kao <powen.kao@xxxxxxxxxxxx>
reviewed-by:  Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>
---
drivers/ufs/core/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index a15a5a78160c..21e3bf5d8f08 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -8548,7 +8548,7 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params)
hba->scsi_host_added = true;
}
/* MCQ may be disabled if ufshcd_alloc_mcq() fails */
- if (is_mcq_supported(hba) && use_mcq_mode)
+ if (is_mcq_supported(hba))
ufshcd_config_mcq(hba);
}