Re: [PATCH 1/2] Mips: ls2k1000: dts: add the display controller device node

[suijingfeng]

On 2023/2/23 15:58, Krzysztof Kozlowski wrote:
> On 23/02/2023 04:19, Sui jingfeng wrote:
> > Hi,
> >
> > On 2023/2/23 02:32, Krzysztof Kozlowski wrote:
> > > On 22/02/2023 17:55, suijingfeng wrote:
> > > > The display controller is a pci device, it's pci vendor id is
> > > > 0x0014, it's pci device id is 0x7a06.
> > > >
> > > > Signed-off-by: suijingfeng <suijingfeng@xxxxxxxxxxx>
> > > > ---
> > > >    .../boot/dts/loongson/loongson64-2k1000.dtsi  | 21 +++++++++++++++++++
> > > >    1 file changed, 21 insertions(+)
> > > >
> > > > diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> > > > index 8143a61111e3..a528af3977d9 100644
> > > > --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> > > > +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> > > > @@ -31,6 +31,18 @@ memory@200000 {
> > > >    			<0x00000001 0x10000000 0x00000001 0xb0000000>; /* 6912 MB at 4352MB */
> > > >    	};
> > > >    
> > > > +	reserved-memory {
> > > > +		#address-cells = <2>;
> > > > +		#size-cells = <2>;
> > > > +		ranges;
> > > > +
> > > > +		display_reserved: framebuffer@30000000 {
> > > > +			compatible = "shared-dma-pool";
> > > > +			reg = <0x0 0x30000000 0x0 0x04000000>; /* 64M */
> > > > +			linux,cma-default;
> > > > +		};
> > > > +	};
> > > > +
> > > >    	cpu_clk: cpu_clk {
> > > >    		#clock-cells = <0>;
> > > >    		compatible = "fixed-clock";
> > > > @@ -198,6 +210,15 @@ sata@8,0 {
> > > >    				interrupt-parent = <&liointc0>;
> > > >    			};
> > > >    
> > > > +			display-controller@6,0 {
> > > > +				compatible = "loongson,ls2k1000-dc";
> > > > +
> > > > +				reg = <0x3000 0x0 0x0 0x0 0x0>;
> > > > +				interrupts = <28 IRQ_TYPE_LEVEL_LOW>;
> > > > +				interrupt-parent = <&liointc0>;
> > > > +				memory-region = <&display_reserved>;
> > > NAK.
> > Err :(,  please give me a chance to explain
> > > Test your code against the bindings you send.
> > I can guarantee to you that I test may code more than twice. The code
> > used to testing is listed at link [1].
> I wrote - test against the bindings. I don't believe that it was tested.
> Please paste the output of the testing (dtbs_check).

I *do* run the test against the bindings and the test result say nothing.

I reset my modify today made, then re-run the test again.

I'm telling the truth: the test result say nothing. I paste the log at 
below:

make -j$(nproc) ARCH=loongarch 
CROSS_COMPILE=loongarch64-unknown-linux-gnu- dt_binding_check 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/loongson/loongson,display-controller.yaml 
dtbs_check 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/loongson/loongson,display-controller.yaml

  DTEX 
Documentation/devicetree/bindings/display/loongson/loongson,display-controller.example.dts
  DTC_CHK 
Documentation/devicetree/bindings/display/loongson/loongson,display-controller.example.dtb


I remember, if there anything wrong, rob's test robot will complain.

let's wait and witness.

> > This patchset  mainly used to illustrate how  we made the driver in [1]
> > usable on our SoC platform.
> >
> > > It's the same
> > > patchset. You basically send something which the same moment is incorrect.
> > Loongson display controller IP has been integrated in both Loongson
> > North Bridge chipset(ls7a1000 and ls7a2000) and Loongson SoCs(ls2k1000
> > and ls2k2000 etc), it even has been included in Loongson BMC(ls2k0500 bmc)
> > products.
> I don't understand how your reply here is relevant to incorrect bindings
> or incorrect DTS according to bindings.

Ok, now I know that you refer to the bindings.

I'm a newbie at DT bindings, but i will correct all of the problem you 
mentioned.

It takes a few time, thanks for  your valuable advice.

> Best regards,
> Krzysztof