Re: [PATCH 1/2] tty: ipwireless: move Kconfig entry to tty

From: Arnd Bergmann
Date: Thu Feb 23 2023 - 03:20:54 EST


On Wed, Feb 22, 2023, at 09:50, Jiri Slaby (SUSE) wrote:
> The ipwireless' Kconfig entry is currently sitting in char/pcmcia. But
> the driver is in tty/. So move the entry to tty/ too.
>
> First, it makes sense to have the entry along the driver. Second, whole
> char/pcmcia is about to pass away.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
> Cc: Jiri Kosina <jikos@xxxxxxxxxx>
> Cc: David Sterba <dsterba@xxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

This is clearly correct

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

In Dominik's list from
https://lore.kernel.org/all/Y07d7rMvd5++85BJ@xxxxxxxxxxxxxxxxxxxxxxxx/

he had listed this driver as 'some activity in 2021', but all I can
find are treewide cleanups (mostly from you) after some work by David
in 2008 and Dominik's own PCMCIA rework in 2010. My guess is that
most likely this driver can be removed entirely, but you and David
are the ones who know if there are still users.

Arnd