RE: [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules

From: DLG Adam Ward
Date: Wed Feb 22 2023 - 17:41:04 EST


On 22/02/2023 12:15, Nick Alcock wrote:
>Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it is not (false positives), and modprobe might succeed rather than failing with a suitable error message.
>
>So remove it in the files in this commit, none of which can be built as modules.

Makes sense - but if you need to do a V2, would you mind removing the erroneous claim on DA9055 at the same time?
https://elixir.bootlin.com/linux/latest/source/drivers/mfd/Kconfig#L364
Strangely, seems it was always there, yet always bool...

Reviewed-by: Adam Ward <DLG-Adam.Ward.opensource@xxxxxxxxxxxxxx>