Re: [PATCH v2 03/16] thermal: Remove debug or error messages in get_temp() ops

From: Florian Fainelli
Date: Wed Feb 22 2023 - 14:23:17 EST


On 2/21/23 10:06, Daniel Lezcano wrote:
Some get_temp() ops implementation are showing an error or a debug
message if the reading of the sensor fails.

The debug message is already displayed from the call site of this
ops. So we can remove it.

On the other side, the error should not be displayed because in
production that can raise tons of messages.

Finally, some drivers are showing a debug message with the
temperature, this is also accessible through the trace from the core
code in the temperature_update() function.

Another benefit is the dev_* messages are accessing the thermal zone
device field from the structure, so we encapsulate even more the code
by preventing these accesses.

Remove those messages.

Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> #Armada

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> #brcmstb_thermal.c
--
Florian