Re: [PATCH 21/27] kbuild, dma-mapping: benchmark: remove MODULE_LICENSE in non-modules

From: Christoph Hellwig
Date: Wed Feb 22 2023 - 09:50:36 EST


Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

On Wed, Feb 22, 2023 at 12:14:47PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules.

.. but this seems like a really odd design. How is this going to
continue working once we can autogenerate the module license section
from the SPDX tags, which we eventually really should?