Re: [PATCH v2] net: dccp: delete redundant ackvec record in dccp_insert_options()

[Eric Dumazet]

On Wed, Feb 22, 2023 at 7:25 AM Hangyu Hua <hbh25y@xxxxxxxxx> wrote:
>
> A useless record can be insert into av_records when dccp_insert_options()
> fails after dccp_insert_option_ackvec(). Repeated triggering may cause
> av_records to have a lot of useless record with the same avr_ack_seqno.

Do you have a repro for this bug ?
It is not clear if this can actually happen.
Presumably skb are sized so that they can hold all possible standard
DCCP options.
DCCP_MAX_OPT_LEN is 992 bytes.

Fact that your first patch was not even compiled is not giving us a good signal.