Re: [PATCH v2 02/10] dt-bindings: gpu: mali-bifrost: Split out MediaTek power-domains variation

From: Chen-Yu Tsai
Date: Wed Feb 22 2023 - 02:58:49 EST


On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
>
> In preparation for adding new bindings for new MediaTek SoCs, split out
> the power-domain-names and power-domainsvariation from the `else` in

^ missing space

Otherwise,

Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>

> the current mediatek,mt8183-mali conditional.
>
> The sram-supply part is left in place to be disallowed for anything
> that is not compatible with "mediatek,mt8183-mali" as this regulator
> is MediaTek-specific and it is, and will ever be, used only for this
> specific string due to the addition of the mediatek-regulator-coupler
> driver.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> index 02699d389be1..ac174c17e25f 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> @@ -145,6 +145,18 @@ allOf:
> - power-domains
> - resets
> - reset-names
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mediatek,mt8183-mali
> + then:
> + properties:
> + power-domains:
> + maxItems: 1
> + power-domain-names: false
> - if:
> properties:
> compatible:
> @@ -166,9 +178,6 @@ allOf:
> - power-domain-names
> else:
> properties:
> - power-domains:
> - maxItems: 1
> - power-domain-names: false
> sram-supply: false
> - if:
> properties:
> --
> 2.39.2
>