Re: [PATCH v10 1/9] dt-bindings: mfd: ti,j721e-system-controller: Fix mux node regex

From: Vignesh Raghavendra
Date: Tue Feb 21 2023 - 09:00:15 EST




On 21/02/23 5:36 pm, Ravi Gunasekaran wrote:
> mux-controller nodes may not have "reg" property. Update the regex
> for such nodes to resolve the dtbs warnings
>
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@xxxxxx>
> ---
> .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> index 76ef4352e13c..532bfa45e6a0 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> @@ -45,7 +45,7 @@ properties:
>
> patternProperties:
> # Optional children
> - "^mux-controller@[0-9a-f]+$":
> + "^mux-controller(@|-)[0-9a-f]+$":

Hmm. mmio-mux bindings allow reg property. Why can't we add the same to
mux-controller node in 2/9 ?

> type: object
> description:
> This is the SERDES lane control mux.
> @@ -94,6 +94,12 @@ examples:
> /* SERDES4 lane0/1/2/3 select */
> };
>
> + usb_serdes_mux: mux-controller-80 {
> + compatible = "mmio-mux";
> + #mux-control-cells = <1>;
> + mux-reg-masks = <0x0 0x8000000>;
> + };
> +
> clock-controller@4140 {
> compatible = "ti,am654-ehrpwm-tbclk", "syscon";
> reg = <0x4140 0x18>;