Re: [PATCH v4 1/6] Update Kconfig and Makefile.

[Danny Tsen]

Hi Herbert,

Thanks for the explanation.  Will re-post the patch series.

Thanks.

-Danny

On 2/20/23 8:59 PM, Herbert Xu wrote:
> On Mon, Feb 20, 2023 at 08:57:24PM -0600, Danny Tsen wrote:
> > Hi Herbert,
> >
> > I am not sure why my patch has to build one-by-one?  I compiled with one
> > make.  Here is the output.
> >
> >    CALL    scripts/checksyscalls.sh
> >    DESCEND objtool
> >    CC [M]  arch/powerpc/crypto/aes-gcm-p10-glue.o
> >    AS [M]  arch/powerpc/crypto/aes-gcm-p10.o
> >    AS [M]  arch/powerpc/crypto/ghashp8-ppc.o
> >    AS [M]  arch/powerpc/crypto/aesp8-ppc.o
> >    LD [M]  arch/powerpc/crypto/aes-gcm-p10-crypto.o
> >    CHK     kernel/kheaders_data.tar.xz
> >    MODPOST Module.symvers
> >    CC [M]  arch/powerpc/crypto/aes-gcm-p10-crypto.mod.o
> >    LD [M]  arch/powerpc/crypto/aes-gcm-p10-crypto.ko
> >
> > Can Stephen explain why he is compiling one-by-one?  Any output I can see.
> Your patch-series should be bisectable.  That is, if I apply
> only the first patch, it should still build in all configurations.
>
> Your first patch only adds the Kconfig option and Makefile rules
> without any actual code.  So it will fail to build because the
> code is simply not there.
>
> Normally we put the Kconfig/Makefile update at the end of the
> series to prevent this.
>
> Cheers,