Re: [PATCH v4 1/6] Update Kconfig and Makefile.

From: Danny Tsen
Date: Mon Feb 20 2023 - 21:57:53 EST


Hi Herbert,

I am not sure why my patch has to build one-by-one?  I compiled with one make.  Here is the output.

  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  CC [M]  arch/powerpc/crypto/aes-gcm-p10-glue.o
  AS [M]  arch/powerpc/crypto/aes-gcm-p10.o
  AS [M]  arch/powerpc/crypto/ghashp8-ppc.o
  AS [M]  arch/powerpc/crypto/aesp8-ppc.o
  LD [M]  arch/powerpc/crypto/aes-gcm-p10-crypto.o
  CHK     kernel/kheaders_data.tar.xz
  MODPOST Module.symvers
  CC [M]  arch/powerpc/crypto/aes-gcm-p10-crypto.mod.o
  LD [M]  arch/powerpc/crypto/aes-gcm-p10-crypto.ko

Can Stephen explain why he is compiling one-by-one?  Any output I can see.

Thanks.

-Danny

On 2/20/23 8:45 PM, Herbert Xu wrote:
On Mon, Feb 20, 2023 at 03:42:19PM -0500, Danny Tsen wrote:
Defined CRYPTO_AES_GCM_P10 in Kconfig to support AES/GCM
stitched implementation for Power10 or later CPU.

Added a new module driver aes-gcm-p10-crypto.

Signed-off-by: Danny Tsen <dtsen@xxxxxxxxxxxxx>
---
arch/powerpc/crypto/Kconfig | 17 +++++++++++++++++
arch/powerpc/crypto/Makefile | 13 +++++++++++++
2 files changed, 30 insertions(+)
Stephen mentioned this before, your patches must compile one-by-one.
This patch doesn't build by itself so you should fix it.

Thanks,