Re: [PATCH v1 07/17] thermal/hwmon: Use the thermal API instead tampering the internals

[Daniel Lezcano]

On 20/02/2023 15:11, Guenter Roeck wrote:
> On Mon, Feb 20, 2023 at 02:34:08PM +0100, Daniel Lezcano wrote:
> > Hi Guenter,
> >
> > my script should have Cc'ed you but it didn't, so just a heads up this patch
> > ;)
> >
> > On 19/02/2023 15:36, Daniel Lezcano wrote:
> > > In this function, there is a guarantee the thermal zone is registered.
> > >
> > > The sysfs hwmon unregistering will be blocked until we exit the
> > > function. The thermal zone is unregistered after the sysfs hwmon is
> > > unregistered.
> > >
> > > When we are in this function, the thermal zone is registered.
> > >
> > > We can call the thermal_zone_get_crit_temp() function safely and let
> > > the function use the lock which is private the thermal core code.
>
> Hmm, if you say so. That very same call used to cause a crash in
> Chromebooks, which is why I had added the locking.

Mmh, I see. I guess we can assume thermal_hwmon is part of the core code 
and remove this change.


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog