Re: [PATCH v1 06/17] thermal: Don't use 'device' internal thermal zone structure field

From: Balsam CHIHI
Date: Mon Feb 20 2023 - 05:50:57 EST


On Sun, Feb 19, 2023 at 3:38 PM Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:
>
> Some drivers are directly using the thermal zone's 'device' structure
> field.
>
> Use the driver device pointer instead of the thermal zone device when
> it is available.
>
> Remove the traces when they are duplicate with the traces in the core
> code.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---

> drivers/thermal/mediatek/lvts_thermal.c | 4 +-

> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 86d280187c83..a65a81114cc5 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -305,7 +305,7 @@ static int lvts_set_trips(struct thermal_zone_device *tz, int low, int high)
> * 14-0 : Raw temperature for threshold
> */
> if (low != -INT_MAX) {
> - dev_dbg(&tz->device, "Setting low limit temperature interrupt: %d\n", low);
> + pr_debug("%s: Setting low limit temperature interrupt: %d\n", tz->type, low);
> writel(raw_low, LVTS_H2NTHRE(base));
> }
>
> @@ -318,7 +318,7 @@ static int lvts_set_trips(struct thermal_zone_device *tz, int low, int high)
> *
> * 14-0 : Raw temperature for threshold
> */
> - dev_dbg(&tz->device, "Setting high limit temperature interrupt: %d\n", high);
> + pr_debug("%s: Setting high limit temperature interrupt: %d\n", tz->type, high);
> writel(raw_high, LVTS_HTHRE(base));
>
> return 0;

for MediaTek LVTS :

Reviewed-by: Balsam CHIHI <bchihi@xxxxxxxxxxxx>