Re: [PATCH] wifi: ath11k: fix SAC bug on peer addition with sta band migration

From: Kalle Valo
Date: Mon Feb 20 2023 - 03:58:04 EST


Christian Marangi <ansuelsmth@xxxxxxxxx> wrote:

> Fix sleep in atomic context warning detected by Smatch static checker
> analyzer.
>
> Following the locking pattern for peer_rhash_add lock tbl_mtx_lock mutex
> always even if sta is not transitioning to another band.
> This is peer_add function and a more secure locking should not cause
> performance regression.
>
> Fixes: d673cb6fe6c0 ("wifi: ath11k: fix peer addition/deletion error on sta band migration")
> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>

I assume you only compile tested this and I'll add that to the commit log. It's
always good to know how the patch was tested.

--
https://patchwork.kernel.org/project/linux-wireless/patch/20230209222622.1751-1-ansuelsmth@xxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches