RE: [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function

From: MyungJoo Ham
Date: Sun Feb 19 2023 - 23:38:46 EST


>--------- Original Message ---------
>Sender : 이범우 <bw365.lee@xxxxxxxxxxx>Product S/W Lab(VD)/삼성전자
>Date : 2023-02-17 17:48 (GMT+9)
>Title : [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function
> 
>The cable allocation part is functionalized from extcon_dev_register.
>
>Signed-off-by: Bumwoo Lee <bw365.lee@xxxxxxxxxxx>

...

>+        if (extcon_alloc_cables(edev))
>+                goto err_alloc_cables;
> 

You are abandoning error return values, here.
Please return appropriate error codes.

Cheers,
MyungJoo