drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:1580 rtl8xxxu_print_chipinfo() warn: always true condition '(priv->chip_cut <= 15) => (0-15 <= 15)'

From: kernel test robot
Date: Sun Feb 19 2023 - 19:17:58 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 925cf0457d7e62ce08878ffb789189ac08ca8677
commit: 7b0ac469e331d9f9fd77f4ebb7a6322f5562db67 wifi: rtl8xxxu: Recognise all possible chip cuts
date: 4 months ago
config: x86_64-randconfig-m001-20230213 (https://download.01.org/0day-ci/archive/20230220/202302200805.crse1DV5-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202302200805.crse1DV5-lkp@xxxxxxxxx/

New smatch warnings:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:1580 rtl8xxxu_print_chipinfo() warn: always true condition '(priv->chip_cut <= 15) => (0-15 <= 15)'

Old smatch warnings:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5675 rtl8xxxu_c2hcmd_callback() warn: potential spectre issue 'rtl8xxxu_legacy_ratetable' [r] (local cap)

vim +1580 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c

1573
1574 static void rtl8xxxu_print_chipinfo(struct rtl8xxxu_priv *priv)
1575 {
1576 struct device *dev = &priv->udev->dev;
1577 char cut = '?';
1578
1579 /* Currently always true: chip_cut is 4 bits. */
> 1580 if (priv->chip_cut <= 15)
1581 cut = 'A' + priv->chip_cut;
1582
1583 dev_info(dev,
1584 "RTL%s rev %c (%s) %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n",
1585 priv->chip_name, cut, priv->chip_vendor, priv->tx_paths,
1586 priv->rx_paths, priv->ep_tx_count, priv->has_wifi,
1587 priv->has_bluetooth, priv->has_gps, priv->hi_pa);
1588
1589 dev_info(dev, "RTL%s MAC: %pM\n", priv->chip_name, priv->mac_addr);
1590 }
1591

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests