Re: [PATCH net-next v1 1/1] net: openvswitch: ovs_packet_cmd_execute put sw_flow mainbody in stack

From: Eddy Tao
Date: Sun Feb 19 2023 - 09:47:03 EST


Hi, Simon:

    Thanks for looking into this.

The revisions i proposed are complementary for the same purpose, and also reside in the same code segment.

I named them 2 items to clarify the details. Maybe it would be better to name them 2 steps in the same revision to avoid confusion.


And yes, i do have some performance result below

Testing topology

            |-----|
      nic1--|     |--nic1
      nic2--|     |--nic2
VM1(16cpus) | ovs |   VM2(16 cpus)
      nic3--|     |--nic3
      nic4--|     |--nic4
            |-----|
2 netperf client threads on each vnic

netperf -H $peer -p $((port+$i)) -t UDP_RR  -l 60 -- -R 1 -r 8K,8K
netperf -H $peer -p $((port+$i)) -t TCP_RR  -l 60 -- -R 1 -r 120,240
netperf -H $peer -p $((port+$i)) -t TCP_CRR -l 60 -- -R 1 -r 120,240

  Mode Iterations   Variance    Average

UDP_RR         10      %1.33      48472 ==> before the change
UDP_RR         10      %2.13      49130 ==> after  the change

TCP_RR         10      %4.56      79686 ==> before the change
TCP_RR         10      %3.42      79833 ==> after  the change

TCP_CRR        10      %0.16      20596 ==> before the change
TCP_CRR        10      %0.11      21179 ==> after  the change

Thanks

eddy