Re: [PATCH v2 1/7] KVM: selftests: x86: Add a working xstate data structure

From: Chao Gao
Date: Sun Feb 19 2023 - 03:33:23 EST


On Tue, Feb 14, 2023 at 06:46:00PM +0000, Mingwei Zhang wrote:
>- /* xsave data for guest_code */
>- xsavedata = vm_vaddr_alloc_pages(vm, 3);
>- memset(addr_gva2hva(vm, xsavedata), 0, 3 * getpagesize());
>- vcpu_args_set(vcpu, 3, amx_cfg, tiledata, xsavedata);
>+ /* XSAVE state for guest_code */
>+ xstate = vm_vaddr_alloc_pages(vm, DIV_ROUND_UP(XSAVE_SIZE, PAGE_SIZE));
>+ memset(addr_gva2hva(vm, xstate), 0, DIV_ROUND_UP(XSAVE_SIZE, PAGE_SIZE));

^ this should be the size in bytes instead of in pages. Right?