Re: [PATCH v2] ext4: Fix function prototype mismatch for ext4_feat_ktype

From: Theodore Ts'o
Date: Sun Feb 19 2023 - 00:42:31 EST


On Wed, 4 Jan 2023 13:09:12 -0800, Kees Cook wrote:
> With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG),
> indirect call targets are validated against the expected function
> pointer prototype to make sure the call target is valid to help mitigate
> ROP attacks. If they are not identical, there is a failure at run time,
> which manifests as either a kernel panic or thread getting killed.
>
> ext4_feat_ktype was setting the "release" handler to "kfree", which
> doesn't have a matching function prototype. Add a simple wrapper
> with the correct prototype.
>
> [...]

Applied, thanks!

[1/1] ext4: Fix function prototype mismatch for ext4_feat_ktype
commit: d99a55a94a0db8eda4a336a6f21730b844b8d2d2

Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>